Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update feature documentation #3534

Merged
merged 3 commits into from
Mar 3, 2023
Merged

Update feature documentation #3534

merged 3 commits into from
Mar 3, 2023

Conversation

teoxoy
Copy link
Member

@teoxoy teoxoy commented Feb 27, 2023

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Connections
closes #3266

Description

  • Update feature documentation

  • Update/fix deno's feature related bindings

  • Rename the following features to be in line with the spec:

    • SHADER_FLOAT16 -> SHADER_F16
    • SHADER_FLOAT64 -> SHADER_F64
    • SHADER_INT16 -> SHADER_I16
    • TEXTURE_COMPRESSION_ASTC_LDR -> TEXTURE_COMPRESSION_ASTC
    • WRITE_TIMESTAMP_INSIDE_PASSES -> TIMESTAMP_QUERY_INSIDE_PASSES

Testing
N/A

@teoxoy
update feature documentation
23fa712 
rename:
SHADER_FLOAT16 -> SHADER_F16
SHADER_FLOAT64 -> SHADER_F64
SHADER_INT16 -> SHADER_I16
TEXTURE_COMPRESSION_ASTC_LDR -> TEXTURE_COMPRESSION_ASTC
WRITE_TIMESTAMP_INSIDE_PASSES -> TIMESTAMP_QUERY_INSIDE_PASSES
@teoxoy teoxoy requested a review from crowlKats as a code owner February 27, 2023 16:44
cwfitzgerald
cwfitzgerald requested changes Mar 1, 2023
View reviewed changes
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, minor things

wgpu-types/src/lib.rs Outdated Show resolved Hide resolved
wgpu/examples/skybox/main.rs Outdated Show resolved Hide resolved
@teoxoy teoxoy requested a review from cwfitzgerald March 2, 2023 20:57
@cwfitzgerald cwfitzgerald merged commit ac689cb into gfx-rs:master Mar 3, 2023
@teoxoy teoxoy deleted the update-ext branch March 3, 2023 17:27
This was referenced Oct 11, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwfitzgerald cwfitzgerald cwfitzgerald approved these changes

@crowlKats crowlKats Awaiting requested review from crowlKats

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Features docs
2 participants
@teoxoy @cwfitzgerald